From 82289edc14b78e50cdf062790543162780d99d4b Mon Sep 17 00:00:00 2001
From: elvez <elvez@3ecf2c5c-341e-0410-92b4-d18e462d057c>
Date: Thu, 3 Aug 2006 01:34:49 +0000
Subject: [PATCH] - Corrected a potentially disastrous automatic int->uint
 conversion in TextSimulation - Make test-history run by commenting some
 "dangerous" lines - Added a couple of comments to
 SchedulablesWidget::update() in the hope the may be useful to others in
 finding where the bug resides...

git-svn-id: svn://svn.gna.org/svn/sgpemv2/trunk@818 3ecf2c5c-341e-0410-92b4-d18e462d057c
---
 src/schedulables_widget.cc    | 6 ++++++
 src/testsuite/test-history.cc | 9 +++++----
 src/text_simulation.cc        | 8 +++++++-
 3 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/src/schedulables_widget.cc b/src/schedulables_widget.cc
index 81b58d2..96aa7ed 100644
--- a/src/schedulables_widget.cc
+++ b/src/schedulables_widget.cc
@@ -55,8 +55,14 @@ SchedulablesWidget::update(const History& history)
   unsigned int w = get_allocation().get_width();
   _h = calc_height(history);
 
+  // FIXME TO THE EXPERT: this assertion fails. 
+  // is this important???
+  assert(is_drawable());
+  
   // FIXME : write me using double buffering
   // PROBLEM : get_window() seems to return a null pointer!!!
+  // I read on the web that get_window() returns a null pointer
+  // if the widget has not been realized
   _buf = Gdk::Pixmap::create(get_window(), w, _h);
   cairo_t* ctx = gdk_cairo_create(_buf->gobj());
 
diff --git a/src/testsuite/test-history.cc b/src/testsuite/test-history.cc
index 84a3129..daf925a 100644
--- a/src/testsuite/test-history.cc
+++ b/src/testsuite/test-history.cc
@@ -270,8 +270,9 @@ main(int argc, char** argv)
 
   info << "Done adding required data by using the History factory interface\n";
 
-  const Environment::SubRequestQueue res1_queue = environment.get_request_queue(res1.first);
-  const Environment::SubRequestQueue res2_queue = environment.get_request_queue(res2.first);
+  // FIXME
+  // const Environment::SubRequestQueue res1_queue = environment.get_request_queue(res1.first);
+  // const Environment::SubRequestQueue res2_queue = environment.get_request_queue(res2.first);
 
   test << "Checking if the environment contains the correct request queues... ";
   
@@ -308,7 +309,7 @@ main(int argc, char** argv)
 //   }
 //   else
 //     test << "FAIL";
-//   test << endl;
+   test << endl;
 
  
   ConcreteEnvironment* environment1 = new ConcreteEnvironment(environment);  
@@ -444,7 +445,7 @@ main(int argc, char** argv)
   
   h.remove(res1.first);
 
-  info << "Checking if history has size 1 after removing a resource... ";
+  test << "Checking if history has size 1 after removing a resource... ";
 
   if(h.get_size() == 1)
     test << "PASS";
diff --git a/src/text_simulation.cc b/src/text_simulation.cc
index b07bc5b..79081d2 100644
--- a/src/text_simulation.cc
+++ b/src/text_simulation.cc
@@ -1413,7 +1413,13 @@ TextSimulation::update(const History& changed_history)
   /// therefore, the last snapshot on the history refers
   /// to instant (history.get_size() - 2).
   // this is a damn uint, so we must hack and hack
-  int printed_instant = changed_history.get_size() > 1 ? changed_history.get_size() - 2 : -1;
+  int printed_instant;
+ 
+  if(changed_history.get_size() > 1)
+    printed_instant = static_cast<int>(changed_history.get_size()) - 2;
+  else
+    printed_instant = -1;
+
   oss << ">>>> " << printed_instant << _("\nREADY QUEUE: { ");
 
   p_stdout(oss.str());