From 075e12d14d75efeebc9edaaeee83e59cad7efd0c Mon Sep 17 00:00:00 2001 From: tchernobog Date: Thu, 23 Feb 2006 09:26:27 +0000 Subject: [PATCH] - Add note that building with --disable-shared at the moment doesn't work git-svn-id: svn://svn.gna.org/svn/sgpemv2/trunk@393 3ecf2c5c-341e-0410-92b4-d18e462d057c --- Makefile.am | 3 ++- doc/sgpem2uman.texi | 4 ++++ src/backend/pyloader/python_policy.cc | 3 ++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 613b90a..a0dd0a4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -273,7 +273,8 @@ _sgpem_la_CPPFLAGS = \ -I@top_srcdir@/src/backend \ $(SWIG_PYTHON_CPPFLAGS) \ $(GLIBMM_CFLAGS) -_sgpem_la_LDFLAGS = -module $(GLIBMM_LDFLAGS) +_sgpem_la_LDFLAGS = -module -export-dynamic \ + $(GLIBMM_LDFLAGS) _sgpem_la_LIBADD = src/backend/libbackend.la \ $(GLIBMM_LIBS) _sgpem_la_SOURCES = $(wrappers) diff --git a/doc/sgpem2uman.texi b/doc/sgpem2uman.texi index df639d3..a7a22eb 100644 --- a/doc/sgpem2uman.texi +++ b/doc/sgpem2uman.texi @@ -210,6 +210,10 @@ For example, on my machine, I would use: @end example @sp 2 +@strong{Warning}: at the moment, we are aware that passing +@option{--disable-shared} to configure doesn't work. We'll look into it +sooner or later, but in the meantime just build shared libraries. + @noindent Once succesfully configured SGPEMv2, just type: @example @command{make} diff --git a/src/backend/pyloader/python_policy.cc b/src/backend/pyloader/python_policy.cc index 937ede1..aae5edd 100644 --- a/src/backend/pyloader/python_policy.cc +++ b/src/backend/pyloader/python_policy.cc @@ -103,7 +103,8 @@ PythonPolicy::sort_queue(Scheduler::event event) const PyObject* pEvent = PyInt_FromLong(event); PyObject* pMethodName = PyString_FromString("async_sort_queue"); PyObject* retval = PyObject_CallMethodObjArgs(_adapter, pMethodName, pEvent, NULL); - Py_DECREF(retval); + // Why we haven't to decref this? + // Py_DECREF(retval); Py_DECREF(pMethodName); Py_DECREF(pEvent);