From 5bec6e8fdc9b79b5b7edba4334ea66dac323897e Mon Sep 17 00:00:00 2001
From: Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
Date: Fri, 8 Jul 2022 10:29:16 -0300
Subject: [PATCH] project: Remove all visible=True properties

Start the GTK4 port by cleaning up all visible=True properties,
since widgets are visible by default on GTK4.
---
 libmalcontent-ui/restrict-applications-dialog.ui  |  6 +-----
 .../restrict-applications-selector.ui             |  2 --
 libmalcontent-ui/user-controls.ui                 | 15 ---------------
 malcontent-control/carousel.ui                    | 10 ----------
 malcontent-control/main.ui                        | 14 --------------
 malcontent-control/user-selector.ui               |  1 -
 6 files changed, 1 insertion(+), 47 deletions(-)

diff --git a/libmalcontent-ui/restrict-applications-dialog.ui b/libmalcontent-ui/restrict-applications-dialog.ui
index c96936b..353cf49 100644
--- a/libmalcontent-ui/restrict-applications-dialog.ui
+++ b/libmalcontent-ui/restrict-applications-dialog.ui
@@ -10,16 +10,12 @@
     <property name="search-enabled">False</property>
     <child>
       <object class="HdyPreferencesPage">
-        <property name="visible">True</property>
         <child>
           <object class="HdyPreferencesGroup" id="group">
-            <property name="visible">True</property>
             <!-- Translated dynamically: -->
             <property name="description">Restrict {username} from using the following installed applications.</property>
             <child>
-              <object class="MctRestrictApplicationsSelector" id="selector">
-                <property name="visible">True</property>
-              </object>
+              <object class="MctRestrictApplicationsSelector" id="selector" />
             </child>
           </object>
         </child>
diff --git a/libmalcontent-ui/restrict-applications-selector.ui b/libmalcontent-ui/restrict-applications-selector.ui
index f139286..813c2eb 100644
--- a/libmalcontent-ui/restrict-applications-selector.ui
+++ b/libmalcontent-ui/restrict-applications-selector.ui
@@ -5,12 +5,10 @@
   <template class="MctRestrictApplicationsSelector" parent="GtkBox">
     <child>
       <object class="GtkListBox" id="listbox">
-        <property name="visible">True</property>
         <property name="selection-mode">none</property>
 
         <child type="placeholder">
           <object class="GtkLabel" id="placeholder">
-            <property name="visible">True</property>
             <property name="label" translatable="yes">No applications found to restrict.</property>
           </object>
         </child>
diff --git a/libmalcontent-ui/user-controls.ui b/libmalcontent-ui/user-controls.ui
index 5189f94..3e452cf 100644
--- a/libmalcontent-ui/user-controls.ui
+++ b/libmalcontent-ui/user-controls.ui
@@ -5,13 +5,10 @@
   <template class="MctUserControls" parent="GtkBin">
     <child>
       <object class="HdyPreferencesPage">
-        <property name="visible">True</property>
         <child>
           <object class="HdyPreferencesGroup">
-            <property name="visible">True</property>
             <child>
               <object class="GtkLabel" id="description_label">
-                <property name="visible">True</property>
                 <property name="wrap">True</property>
                 <property name="xalign">0.0</property>
                 <property name="yalign">0.0</property>
@@ -28,11 +25,9 @@
         <!-- Application Usage Restrictions -->
         <child>
           <object class="HdyPreferencesGroup">
-            <property name="visible">True</property>
             <property name="title" translatable="yes">Application Usage Restrictions</property>
             <child>
               <object class="HdyActionRow" id="restrict_web_browsers_row">
-                <property name="visible">True</property>
                 <property name="title" translatable="yes">Restrict _Web Browsers</property>
                 <property name="use_underline">True</property>
                 <property name="activatable_widget">restrict_web_browsers_switch</property>
@@ -41,7 +36,6 @@
                 <property name="subtitle_lines">0</property>
                 <child>
                   <object class="GtkSwitch" id="restrict_web_browsers_switch">
-                    <property name="visible">True</property>
                     <property name="can_focus">True</property>
                     <property name="halign">end</property>
                     <property name="valign">center</property>
@@ -56,7 +50,6 @@
 
             <child>
               <object class="HdyActionRow" id="restrict_applications_row">
-                <property name="visible">True</property>
                 <property name="activatable">True</property>
                 <property name="title" translatable="yes">_Restrict Applications</property>
                 <property name="use_underline">True</property>
@@ -66,7 +59,6 @@
                 <property name="action-name">permissions.restrict-applications</property>
                 <child>
                   <object class="GtkImage">
-                    <property name="visible">True</property>
                     <property name="icon-name">go-next-symbolic</property>
                   </object>
                 </child>
@@ -81,7 +73,6 @@
         <!-- Software Installation Restrictions -->
         <child>
           <object class="HdyPreferencesGroup">
-            <property name="visible">True</property>
             <property name="title" translatable="yes">Software Installation Restrictions</property>
             <child>
               <object class="HdyActionRow" id="restrict_software_installation_row">
@@ -94,7 +85,6 @@
                 <property name="subtitle_lines">0</property>
                 <child>
                   <object class="GtkSwitch" id="restrict_software_installation_switch">
-                    <property name="visible">True</property>
                     <property name="can_focus">True</property>
                     <property name="halign">end</property>
                     <property name="valign">center</property>
@@ -109,7 +99,6 @@
 
             <child>
               <object class="HdyActionRow">
-                <property name="visible">True</property>
                 <property name="title" translatable="yes">Application _Suitability</property>
                 <property name="use_underline">True</property>
                 <property name="activatable_widget">oars_button</property>
@@ -117,7 +106,6 @@
                 <property name="subtitle_lines">0</property>
                 <child>
                   <object class="GtkMenuButton" id="oars_button">
-                    <property name="visible">True</property>
                     <property name="can_focus">True</property>
                     <property name="halign">end</property>
                     <property name="valign">center</property>
@@ -125,11 +113,9 @@
                     <property name="popover">oars_popover</property>
                     <child>
                       <object class="GtkBox">
-                        <property name="visible">True</property>
                         <property name="orientation">horizontal</property>
                         <child>
                           <object class="GtkLabel" id="oars_button_label">
-                            <property name="visible">True</property>
                             <property name="label"></property>
                             <property name="expand">True</property>
                             <property name="halign">start</property>
@@ -138,7 +124,6 @@
                         </child>
                         <child>
                           <object class="GtkImage">
-                            <property name="visible">True</property>
                             <property name="icon-name">pan-down-symbolic</property>
                             <property name="icon-size">4</property><!-- GTK_ICON_SIZE_BUTTON -->
                           </object>
diff --git a/malcontent-control/carousel.ui b/malcontent-control/carousel.ui
index 41db014..02a4992 100644
--- a/malcontent-control/carousel.ui
+++ b/malcontent-control/carousel.ui
@@ -8,12 +8,10 @@
     <property name="reveal-child">True</property>
     <child>
       <object class="GtkOverlay">
-        <property name="visible">True</property>
         <property name="hexpand">True</property>
         <property name="border_width">16</property>
         <child>
           <object class="GtkStack" id="stack">
-            <property name="visible">True</property>
             <property name="transition_duration">400</property>
             <property name="transition_type">GTK_STACK_TRANSITION_TYPE_SLIDE_LEFT_RIGHT</property>
             <style>
@@ -23,10 +21,8 @@
         </child>
         <child type="overlay">
           <object class="GtkOverlay">
-            <property name="visible">True</property>
             <child>
               <object class="GtkBox">
-                <property name="visible">True</property>
                 <property name="orientation">GTK_ORIENTATION_HORIZONTAL</property>
                 <property name="border_width">12</property>
                 <child>
@@ -39,7 +35,6 @@
                     </style>
                     <child>
                       <object class="GtkImage">
-                        <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="icon-size">4</property>
                         <property name="icon_name">go-previous-symbolic</property>
@@ -65,7 +60,6 @@
                     </style>
                     <child>
                       <object class="GtkImage">
-                        <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="icon-size">4</property>
                         <property name="icon_name">go-next-symbolic</property>
@@ -86,17 +80,14 @@
             </child>
             <child type="overlay">
               <object class="GtkBox">
-                <property name="visible">True</property>
                 <property name="valign">GTK_ALIGN_END</property>
                 <style>
                   <class name="carousel-arrow-container"/>
                 </style>
                 <child>
                   <object class="GtkOverlay">
-                    <property name="visible">True</property>
                     <child>
                       <object class="GtkBox" id="arrow">
-                        <property name="visible">True</property>
                         <property name="halign">GTK_ALIGN_END</property>
                         <style>
                           <class name="carousel-arrow"/>
@@ -105,7 +96,6 @@
                     </child>
                     <child type="overlay">
                       <object class="GtkBox">
-                        <property name="visible">True</property>
                         <property name="halign">GTK_ALIGN_END</property>
                         <style>
                           <class name="carousel-inner-arrow"/>
diff --git a/malcontent-control/main.ui b/malcontent-control/main.ui
index 9c9e5a4..1526bfb 100644
--- a/malcontent-control/main.ui
+++ b/malcontent-control/main.ui
@@ -7,17 +7,14 @@
     <property name="default-height">580</property>
     <child>
       <object class="GtkBox">
-        <property name="visible">True</property>
         <property name="orientation">vertical</property>
         <child>
           <object class="HdyHeaderBar" id="header">
             <property name="show-close-button">True</property>
             <!-- Translators: This is the title of the main window -->
             <property name="title" translatable="yes">Parental Controls</property>
-            <property name="visible">True</property>
             <child>
               <object class="GtkMenuButton" id="primary_menu">
-                <property name="visible">True</property>
                 <property name="direction">none</property>
                 <property name="can-focus">True</property>
                 <property name="use-popover">True</property>
@@ -35,15 +32,12 @@
         </child>
         <child>
           <object class="GtkStack" id="main_stack">
-            <property name="visible">True</property>
             <child>
               <object class="GtkBox">
-                <property name="visible">True</property>
                 <property name="orientation">vertical</property>
                 <property name="border_width">0</property>
                 <child>
                   <object class="MctUserSelector" id="user_selector">
-                    <property name="visible">True</property>
                     <property name="user-manager">user_manager</property>
                     <property name="show-administrators">False</property>
                     <accessibility>
@@ -57,7 +51,6 @@
                 </child>
                 <child>
                   <object class="MctUserControls" id="user_controls">
-                    <property name="visible">True</property>
                     <!-- Content is set in code; this string is just a placeholder -->
                     <property name="description">It’s recommended that restrictions are set as part of an ongoing conversation with $name. Read guidance on what to consider.</property>
                     <property name="height-request">270</property>
@@ -75,13 +68,11 @@
 
             <child>
               <object class="HdyStatusPage">
-                <property name="visible">True</property>
                 <property name="title" translatable="yes">Permission Required</property>
                 <property name="description" translatable="yes">Permission is required to view and change user parental controls settings.</property>
                 <property name="icon-name">org.freedesktop.MalcontentControl</property>
                 <child>
                   <object class="GtkLockButton" id="lock_button">
-                    <property name="visible">True</property>
                     <property name="halign">center</property>
                     <property name="can-default">True</property>
                     <property name="has-default">True</property>
@@ -96,14 +87,12 @@
 
             <child>
               <object class="HdyStatusPage">
-                <property name="visible">True</property>
                 <property name="icon-name">system-users-symbolic</property>
                 <property name="title" translatable="yes">No Standard User Accounts</property>
                 <property name="description" translatable="yes">Parental controls can only be applied to standard user
     accounts. These can be created in the user settings.</property>
                 <child>
                   <object class="GtkButton" id="user_accounts_panel_button">
-                    <property name="visible">True</property>
                     <property name="label" translatable="yes">_User Settings</property>
                     <property name="halign">center</property>
                     <property name="can-default">True</property>
@@ -123,13 +112,11 @@
 
             <child>
               <object class="GtkBox">
-                <property name="visible">True</property>
                 <property name="orientation">vertical</property>
                 <property name="hexpand">True</property>
                 <property name="vexpand">True</property>
                 <child type="center">
                   <object class="GtkLabel">
-                    <property name="visible">True</property>
                     <property name="label" translatable="yes">Loading…</property>
                     <attributes>
                       <attribute name="scale" value="1.4"/>
@@ -149,7 +136,6 @@
 
             <child>
               <object class="HdyStatusPage" id="error_page">
-                <property name="visible">True</property>
                 <property name="icon-name">dialog-error-symbolic</property>
               </object>
               <packing>
diff --git a/malcontent-control/user-selector.ui b/malcontent-control/user-selector.ui
index 088d72f..1604595 100644
--- a/malcontent-control/user-selector.ui
+++ b/malcontent-control/user-selector.ui
@@ -5,7 +5,6 @@
   <template class="MctUserSelector" parent="GtkBox">
     <child>
       <object class="MctCarousel" id="carousel">
-        <property name="visible">True</property>
         <property name="hexpand">True</property>
         <signal name="item-activated" handler="carousel_item_activated"/>
       </object>