matteo
/
malcontent
1
0
Fork 0
Code Issues Pull Requests 2 Packages Projects Releases Wiki Activity

user-controls: Relabel ‘allow installation’ as ‘restrict installation’ 

This is part of a move to make all the controls restrictive, rather than
permissive.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #11
This commit is contained in:
Philip Withnall 2020-02-24 16:44:15 +00:00
parent f956fab427
commit 516e3936eb
2 changed files with 78 additions and 72 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

100
libmalcontent-ui/user-controls.c
View File

@ -75,8 +75,8 @@ struct _MctUserControls
GtkGrid parent_instance; GtkGrid parent_instance;
GMenu *age_menu; GMenu *age_menu;
GtkSwitch *allow_system_installation_switch; GtkSwitch *restrict_system_installation_switch;
GtkSwitch *allow_user_installation_switch; GtkSwitch *restrict_user_installation_switch;
GtkSwitch *restrict_web_browsers_switch; GtkSwitch *restrict_web_browsers_switch;
GtkButton *restriction_button; GtkButton *restriction_button;
GtkPopover *restriction_popover; GtkPopover *restriction_popover;
@ -107,9 +107,9 @@ struct _MctUserControls
static gboolean blacklist_apps_cb (gpointer data); static gboolean blacklist_apps_cb (gpointer data);
static void on_allow_installation_switch_active_changed_cb (GtkSwitch *s, static void on_restrict_installation_switch_active_changed_cb (GtkSwitch *s,
GParamSpec *pspec, GParamSpec *pspec,
MctUserControls *self); MctUserControls *self);
static void on_restrict_web_browsers_switch_active_changed_cb (GtkSwitch *s, static void on_restrict_web_browsers_switch_active_changed_cb (GtkSwitch *s,
GParamSpec *pspec, GParamSpec *pspec,
@ -401,8 +401,8 @@ update_oars_level (MctUserControls *self)
static void static void
update_allow_app_installation (MctUserControls *self) update_allow_app_installation (MctUserControls *self)
{ {
gboolean allow_system_installation; gboolean restrict_system_installation;
gboolean allow_user_installation; gboolean restrict_user_installation;
gboolean non_admin_user = TRUE; gboolean non_admin_user = TRUE;
if (self->user_account_type == ACT_USER_ACCOUNT_TYPE_ADMINISTRATOR) if (self->user_account_type == ACT_USER_ACCOUNT_TYPE_ADMINISTRATOR)
@ -410,8 +410,8 @@ update_allow_app_installation (MctUserControls *self)
/* Admins are always allowed to install apps for all users. This behaviour is governed /* Admins are always allowed to install apps for all users. This behaviour is governed
* by flatpak polkit rules. Hence, these hide these defunct switches for admins. */ * by flatpak polkit rules. Hence, these hide these defunct switches for admins. */
gtk_widget_set_visible (GTK_WIDGET (self->allow_system_installation_switch), non_admin_user); gtk_widget_set_visible (GTK_WIDGET (self->restrict_system_installation_switch), non_admin_user);
gtk_widget_set_visible (GTK_WIDGET (self->allow_user_installation_switch), non_admin_user); gtk_widget_set_visible (GTK_WIDGET (self->restrict_user_installation_switch), non_admin_user);
/* If user is admin, we are done here, bail out. */ /* If user is admin, we are done here, bail out. */
if (!non_admin_user) if (!non_admin_user)
@ -421,36 +421,36 @@ update_allow_app_installation (MctUserControls *self)
return; return;
} }
allow_system_installation = mct_app_filter_is_system_installation_allowed (self->filter); restrict_system_installation = !mct_app_filter_is_system_installation_allowed (self->filter);
allow_user_installation = mct_app_filter_is_user_installation_allowed (self->filter); restrict_user_installation = !mct_app_filter_is_user_installation_allowed (self->filter);
/* While the underlying permissions storage allows the system and user settings /* While the underlying permissions storage allows the system and user settings
* to be stored completely independently, force the system setting to OFF if * to be stored completely independently, force the system setting to OFF if
* the user setting is OFF in the UI. This keeps the policy in use for most * the user setting is OFF in the UI. This keeps the policy in use for most
* people simpler. */ * people simpler. */
if (!allow_user_installation) if (restrict_user_installation)
allow_system_installation = FALSE; restrict_system_installation = TRUE;
g_signal_handlers_block_by_func (self->allow_system_installation_switch, g_signal_handlers_block_by_func (self->restrict_system_installation_switch,
on_allow_installation_switch_active_changed_cb, on_restrict_installation_switch_active_changed_cb,
self); self);
g_signal_handlers_block_by_func (self->allow_user_installation_switch, g_signal_handlers_block_by_func (self->restrict_user_installation_switch,
on_allow_installation_switch_active_changed_cb, on_restrict_installation_switch_active_changed_cb,
self); self);
gtk_switch_set_active (self->allow_system_installation_switch, allow_system_installation); gtk_switch_set_active (self->restrict_system_installation_switch, restrict_system_installation);
gtk_switch_set_active (self->allow_user_installation_switch, allow_user_installation); gtk_switch_set_active (self->restrict_user_installation_switch, restrict_user_installation);
g_debug ("Allow system installation: %s", allow_system_installation ? "yes" : "no"); g_debug ("Restrict system installation: %s", restrict_system_installation ? "yes" : "no");
g_debug ("Allow user installation: %s", allow_user_installation ? "yes" : "no"); g_debug ("Restrict user installation: %s", restrict_user_installation ? "yes" : "no");
g_signal_handlers_unblock_by_func (self->allow_system_installation_switch, g_signal_handlers_unblock_by_func (self->restrict_system_installation_switch,
on_allow_installation_switch_active_changed_cb, on_restrict_installation_switch_active_changed_cb,
self); self);
g_signal_handlers_unblock_by_func (self->allow_user_installation_switch, g_signal_handlers_unblock_by_func (self->restrict_user_installation_switch,
on_allow_installation_switch_active_changed_cb, on_restrict_installation_switch_active_changed_cb,
self); self);
} }
@ -539,21 +539,21 @@ blacklist_apps_cb (gpointer data)
} }
static void static void
on_allow_installation_switch_active_changed_cb (GtkSwitch *s, on_restrict_installation_switch_active_changed_cb (GtkSwitch *s,
GParamSpec *pspec, GParamSpec *pspec,
MctUserControls *self) MctUserControls *self)
{ {
/* See the comment about policy in update_allow_app_installation(). */ /* See the comment about policy in update_allow_app_installation(). */
if (s == self->allow_user_installation_switch && if (s == self->restrict_user_installation_switch &&
!gtk_switch_get_active (s) && gtk_switch_get_active (s) &&
gtk_switch_get_active (self->allow_system_installation_switch)) !gtk_switch_get_active (self->restrict_system_installation_switch))
{ {
g_signal_handlers_block_by_func (self->allow_system_installation_switch, g_signal_handlers_block_by_func (self->restrict_system_installation_switch,
on_allow_installation_switch_active_changed_cb, on_restrict_installation_switch_active_changed_cb,
self); self);
gtk_switch_set_active (self->allow_system_installation_switch, FALSE); gtk_switch_set_active (self->restrict_system_installation_switch, TRUE);
g_signal_handlers_unblock_by_func (self->allow_system_installation_switch, g_signal_handlers_unblock_by_func (self->restrict_system_installation_switch,
on_allow_installation_switch_active_changed_cb, on_restrict_installation_switch_active_changed_cb,
self); self);
} }
@ -928,8 +928,8 @@ mct_user_controls_class_init (MctUserControlsClass *klass)
gtk_widget_class_set_template_from_resource (widget_class, "/org/freedesktop/MalcontentUi/ui/user-controls.ui"); gtk_widget_class_set_template_from_resource (widget_class, "/org/freedesktop/MalcontentUi/ui/user-controls.ui");
gtk_widget_class_bind_template_child (widget_class, MctUserControls, age_menu); gtk_widget_class_bind_template_child (widget_class, MctUserControls, age_menu);
gtk_widget_class_bind_template_child (widget_class, MctUserControls, allow_system_installation_switch); gtk_widget_class_bind_template_child (widget_class, MctUserControls, restrict_system_installation_switch);
gtk_widget_class_bind_template_child (widget_class, MctUserControls, allow_user_installation_switch); gtk_widget_class_bind_template_child (widget_class, MctUserControls, restrict_user_installation_switch);
gtk_widget_class_bind_template_child (widget_class, MctUserControls, restrict_web_browsers_switch); gtk_widget_class_bind_template_child (widget_class, MctUserControls, restrict_web_browsers_switch);
gtk_widget_class_bind_template_child (widget_class, MctUserControls, restriction_button); gtk_widget_class_bind_template_child (widget_class, MctUserControls, restriction_button);
gtk_widget_class_bind_template_child (widget_class, MctUserControls, restriction_popover); gtk_widget_class_bind_template_child (widget_class, MctUserControls, restriction_popover);
@ -937,7 +937,7 @@ mct_user_controls_class_init (MctUserControlsClass *klass)
gtk_widget_class_bind_template_child (widget_class, MctUserControls, application_usage_permissions_listbox); gtk_widget_class_bind_template_child (widget_class, MctUserControls, application_usage_permissions_listbox);
gtk_widget_class_bind_template_child (widget_class, MctUserControls, software_installation_permissions_listbox); gtk_widget_class_bind_template_child (widget_class, MctUserControls, software_installation_permissions_listbox);
gtk_widget_class_bind_template_callback (widget_class, on_allow_installation_switch_active_changed_cb); gtk_widget_class_bind_template_callback (widget_class, on_restrict_installation_switch_active_changed_cb);
gtk_widget_class_bind_template_callback (widget_class, on_restrict_web_browsers_switch_active_changed_cb); gtk_widget_class_bind_template_callback (widget_class, on_restrict_web_browsers_switch_active_changed_cb);
gtk_widget_class_bind_template_callback (widget_class, on_restrict_applications_button_clicked_cb); gtk_widget_class_bind_template_callback (widget_class, on_restrict_applications_button_clicked_cb);
gtk_widget_class_bind_template_callback (widget_class, on_restrict_applications_dialog_delete_event_cb); gtk_widget_class_bind_template_callback (widget_class, on_restrict_applications_dialog_delete_event_cb);
@ -989,9 +989,9 @@ mct_user_controls_init (MctUserControls *self)
gtk_popover_bind_model (self->restriction_popover, G_MENU_MODEL (self->age_menu), NULL); gtk_popover_bind_model (self->restriction_popover, G_MENU_MODEL (self->age_menu), NULL);
g_object_bind_property (self->allow_user_installation_switch, "active", g_object_bind_property (self->restrict_user_installation_switch, "active",
self->allow_system_installation_switch, "sensitive", self->restrict_system_installation_switch, "sensitive",
G_BINDING_DEFAULT); G_BINDING_DEFAULT | G_BINDING_INVERT_BOOLEAN);
/* Automatically add separators between rows. */ /* Automatically add separators between rows. */
gtk_list_box_set_header_func (self->application_usage_permissions_listbox, gtk_list_box_set_header_func (self->application_usage_permissions_listbox,
@ -1399,16 +1399,16 @@ mct_user_controls_build_app_filter (MctUserControls *self,
/* App installation */ /* App installation */
if (self->user_account_type != ACT_USER_ACCOUNT_TYPE_ADMINISTRATOR) if (self->user_account_type != ACT_USER_ACCOUNT_TYPE_ADMINISTRATOR)
{ {
gboolean allow_system_installation; gboolean restrict_system_installation;
gboolean allow_user_installation; gboolean restrict_user_installation;
allow_system_installation = gtk_switch_get_active (self->allow_system_installation_switch); restrict_system_installation = gtk_switch_get_active (self->restrict_system_installation_switch);
allow_user_installation = gtk_switch_get_active (self->allow_user_installation_switch); restrict_user_installation = gtk_switch_get_active (self->restrict_user_installation_switch);
g_debug ("\t → %s system installation", allow_system_installation ? "Enabling" : "Disabling"); g_debug ("\t → %s system installation", restrict_system_installation ? "Restricting" : "Allowing");
g_debug ("\t → %s user installation", allow_user_installation ? "Enabling" : "Disabling"); g_debug ("\t → %s user installation", restrict_user_installation ? "Restricting" : "Allowing");
mct_app_filter_builder_set_allow_user_installation (builder, allow_user_installation); mct_app_filter_builder_set_allow_user_installation (builder, !restrict_user_installation);
mct_app_filter_builder_set_allow_system_installation (builder, allow_system_installation); mct_app_filter_builder_set_allow_system_installation (builder, !restrict_system_installation);
} }
} }

50
libmalcontent-ui/user-controls.ui
View File

@ -250,7 +250,7 @@
<property name="activate_on_single_click">False</property> <property name="activate_on_single_click">False</property>
<child> <child>
<object class="GtkListBoxRow"> <object class="GtkListBoxRow">
<property name="visible" bind-source="allow_user_installation_switch" bind-property="visible" bind-flags="default|sync-create" /> <property name="visible" bind-source="restrict_user_installation_switch" bind-property="visible" bind-flags="default|sync-create" />
<property name="can_focus">True</property> <property name="can_focus">True</property>
<property name="activatable">False</property> <property name="activatable">False</property>
<property name="selectable">False</property> <property name="selectable">False</property>
@ -266,18 +266,18 @@
<property name="row-spacing">4</property> <property name="row-spacing">4</property>
<property name="column-spacing">4</property> <property name="column-spacing">4</property>
<child> <child>
<object class="GtkLabel" id="allow_user_installation_label"> <object class="GtkLabel" id="restrict_user_installation_label">
<property name="visible">True</property> <property name="visible">True</property>
<property name="can_focus">False</property> <property name="can_focus">False</property>
<property name="halign">start</property> <property name="halign">start</property>
<property name="hexpand">True</property> <property name="hexpand">True</property>
<property name="ellipsize">end</property> <property name="ellipsize">end</property>
<property name="xalign">0</property> <property name="xalign">0</property>
<property name="label" translatable="yes">Application _Installation</property> <property name="label" translatable="yes">Restrict Application _Installation</property>
<property name="use_underline">True</property> <property name="use_underline">True</property>
<property name="mnemonic_widget">allow_user_installation_switch</property> <property name="mnemonic_widget">restrict_user_installation_switch</property>
<accessibility> <accessibility>
<relation target="allow_user_installation_switch" type="label-for"/> <relation target="restrict_user_installation_switch" type="label-for"/>
</accessibility> </accessibility>
</object> </object>
<packing> <packing>
@ -286,14 +286,14 @@
</packing> </packing>
</child> </child>
<child> <child>
<object class="GtkLabel" id="allow_user_installation_description"> <object class="GtkLabel" id="restrict_user_installation_description">
<property name="visible">True</property> <property name="visible">True</property>
<property name="can_focus">False</property> <property name="can_focus">False</property>
<property name="halign">start</property> <property name="halign">start</property>
<property name="hexpand">True</property> <property name="hexpand">True</property>
<property name="ellipsize">end</property> <property name="ellipsize">end</property>
<property name="xalign">0</property> <property name="xalign">0</property>
<property name="label" translatable="yes">Restricts the user from installing applications.</property> <property name="label" translatable="yes">Prevents the user from installing applications.</property>
<attributes> <attributes>
<attribute name="scale" value="0.88"/> <attribute name="scale" value="0.88"/>
</attributes> </attributes>
@ -301,7 +301,7 @@
<class name="dim-label" /> <class name="dim-label" />
</style> </style>
<accessibility> <accessibility>
<relation target="allow_user_installation_switch" type="description-for"/> <relation target="restrict_user_installation_switch" type="description-for"/>
</accessibility> </accessibility>
</object> </object>
<packing> <packing>
@ -310,12 +310,15 @@
</packing> </packing>
</child> </child>
<child> <child>
<object class="GtkSwitch" id="allow_user_installation_switch"> <object class="GtkSwitch" id="restrict_user_installation_switch">
<property name="visible">True</property> <property name="visible">True</property>
<property name="can_focus">True</property> <property name="can_focus">True</property>
<property name="halign">end</property> <property name="halign">end</property>
<property name="valign">center</property> <property name="valign">center</property>
<signal name="notify::active" handler="on_allow_installation_switch_active_changed_cb" object="MctUserControls" swapped="no" /> <signal name="notify::active" handler="on_restrict_installation_switch_active_changed_cb" object="MctUserControls" swapped="no" />
<style>
<class name="restricts" />
</style>
</object> </object>
<packing> <packing>
<property name="left-attach">1</property> <property name="left-attach">1</property>
@ -330,7 +333,7 @@
<child> <child>
<object class="GtkListBoxRow"> <object class="GtkListBoxRow">
<property name="visible" bind-source="allow_system_installation_switch" bind-property="visible" bind-flags="default|sync-create" /> <property name="visible" bind-source="restrict_system_installation_switch" bind-property="visible" bind-flags="default|sync-create" />
<property name="can_focus">True</property> <property name="can_focus">True</property>
<property name="activatable">False</property> <property name="activatable">False</property>
<property name="selectable">False</property> <property name="selectable">False</property>
@ -346,18 +349,18 @@
<property name="row-spacing">4</property> <property name="row-spacing">4</property>
<property name="column-spacing">4</property> <property name="column-spacing">4</property>
<child> <child>
<object class="GtkLabel" id="allow_system_installation_label"> <object class="GtkLabel" id="restrict_system_installation_label">
<property name="visible">True</property> <property name="visible">True</property>
<property name="can_focus">False</property> <property name="can_focus">False</property>
<property name="halign">start</property> <property name="halign">start</property>
<property name="hexpand">True</property> <property name="hexpand">True</property>
<property name="ellipsize">end</property> <property name="ellipsize">end</property>
<property name="xalign">0</property> <property name="xalign">0</property>
<property name="label" translatable="yes">Application Installation for _Others</property> <property name="label" translatable="yes">Restrict Application Installation for _Others</property>
<property name="use_underline">True</property> <property name="use_underline">True</property>
<property name="mnemonic_widget">allow_system_installation_switch</property> <property name="mnemonic_widget">restrict_system_installation_switch</property>
<accessibility> <accessibility>
<relation target="allow_system_installation_switch" type="label-for"/> <relation target="restrict_system_installation_switch" type="label-for"/>
</accessibility> </accessibility>
</object> </object>
<packing> <packing>
@ -366,14 +369,14 @@
</packing> </packing>
</child> </child>
<child> <child>
<object class="GtkLabel" id="allow_system_installation_description"> <object class="GtkLabel" id="restrict_system_installation_description">
<property name="visible">True</property> <property name="visible">True</property>
<property name="can_focus">False</property> <property name="can_focus">False</property>
<property name="halign">start</property> <property name="halign">start</property>
<property name="hexpand">True</property> <property name="hexpand">True</property>
<property name="ellipsize">end</property> <property name="ellipsize">end</property>
<property name="xalign">0</property> <property name="xalign">0</property>
<property name="label" translatable="yes">Restricts the user from installing applications for all users.</property> <property name="label" translatable="yes">Prevents the user’s application installations from being available to all users.</property>
<attributes> <attributes>
<attribute name="scale" value="0.88"/> <attribute name="scale" value="0.88"/>
</attributes> </attributes>
@ -381,7 +384,7 @@
<class name="dim-label" /> <class name="dim-label" />
</style> </style>
<accessibility> <accessibility>
<relation target="allow_system_installation_switch" type="description-for"/> <relation target="restrict_system_installation_switch" type="description-for"/>
</accessibility> </accessibility>
</object> </object>
<packing> <packing>
@ -390,12 +393,15 @@
</packing> </packing>
</child> </child>
<child> <child>
<object class="GtkSwitch" id="allow_system_installation_switch"> <object class="GtkSwitch" id="restrict_system_installation_switch">
<property name="visible">True</property> <property name="visible">True</property>
<property name="can_focus">True</property> <property name="can_focus">True</property>
<property name="halign">end</property> <property name="halign">end</property>
<property name="valign">center</property> <property name="valign">center</property>
<signal name="notify::active" handler="on_allow_installation_switch_active_changed_cb" object="MctUserControls" swapped="no" /> <signal name="notify::active" handler="on_restrict_installation_switch_active_changed_cb" object="MctUserControls" swapped="no" />
<style>
<class name="restricts" />
</style>
</object> </object>
<packing> <packing>
<property name="left-attach">1</property> <property name="left-attach">1</property>
@ -522,8 +528,8 @@
<widget name="restrict_applications_label" /> <widget name="restrict_applications_label" />
<widget name="restrict_applications_description" /> <widget name="restrict_applications_description" />
<widget name="restriction_label" /> <widget name="restriction_label" />
<widget name="allow_user_installation_label" /> <widget name="restrict_user_installation_label" />
<widget name="allow_system_installation_label" /> <widget name="restrict_system_installation_label" />
</widgets> </widgets>
</object> </object>